BlockingIdentifierGenerator invoked on wrong context under load

[tsegismont]

In BlockingIdentifierGenerator, when a new block is allocated, invocations of generate method are queued:

hibernate-reactive/hibernate-reactive-core/src/main/java/org/hibernate/reactive/id/impl/BlockingIdentifierGenerator.java

Line 94 in 75e5748

queue.add( () -> generate( session, entity ).thenAccept( result::complete ) );

After the result is received, queued tasks are executed:

hibernate-reactive/hibernate-reactive-core/src/main/java/org/hibernate/reactive/id/impl/BlockingIdentifierGenerator.java

Line 87 in 75e5748

list.forEach( Runnable::run );

The problem is that they are executed on the Vert.x context which made the database call, not the context they were operating on when they were queued.

This explains the error logs in quarkusio/quarkus#32533

[Sanne]

Excellent, thanks for investigating!
Seems related to #1587 : the problem is different but for both of them we'll need safety tests under load.

[Sanne]

Fixed now, thanks again @tsegismont - this was really tricky

[tsegismont]

You're welcome, I'm glad it helped