Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Admin / Mods Page with Groups and Members Page #9978

Open
dillchen opened this issue Nov 20, 2024 · 9 comments · May be fixed by #10580
Open

Merge Admin / Mods Page with Groups and Members Page #9978

dillchen opened this issue Nov 20, 2024 · 9 comments · May be fixed by #10580
Assignees
Labels
3 Full day task enhancement New feature or request refinement upcoming-release Should be included in the upcoming release

Comments

@dillchen
Copy link
Contributor

dillchen commented Nov 20, 2024

Description

should merge these two

Project Owner

No response

Bucket ID

No response

User Stories / Acceptance Criteria

  • Admin and Mods should each be treated as default groups, that only have allow list as requirement
  • We should remove one of the two from the sidebar
  • We should display Admin and Mod as a Tag/Optional Group Image

Design Devlink

https://www.figma.com/design/IfwWOjzoyjQP6pnfezZa0q/Mint-and-Burn?node-id=2-14&t=9IxHSRJZMasAKbar-1

Design Screenshot

No response

Additional Context

No response

@dillchen dillchen added this to the groups and admin update milestone Nov 20, 2024
@dillchen dillchen changed the title Merge Admin / Mods with Groups and Members Merge Admin / Mods Page with Groups and Members Page Nov 20, 2024
@sssssabinaaa
Copy link
Contributor

@salman-neslit
Copy link
Collaborator

@dillchen @sssssabinaaa I had question regarding this ticket in the figma design what does these represent are they the roles like admin , moderator, member.

Screenshot 2024-12-16 at 9 58 39 PM

@dillchen
Copy link
Contributor Author

dillchen commented Dec 16, 2024 via email

@salman-neslit
Copy link
Collaborator

salman-neslit commented Dec 18, 2024

@dillchen @Israellund Would you like assistance in deciding how to approach this.

  1. Existing Functionality:

    • On the Admin and Moderator page, you can select an address and assign it a role: Admin, Moderator, or Member.
    • A user can have multiple addresses, and if any one of their addresses is an Admin of a community, the Admin tag is shown for that user.
    • The roles (Admin, Moderator, Member) are currently handled at the address level in both the database schema and the backend logic.
    • A user is considered an Admin of a community in FE if any of their addresses has the Admin role for that community.
  2. New UI Table Requirement:

    • In the new UI, a user’s address is displayed next to their name in the table.
    • This means the same user might appear multiple times in the table if they have multiple addresses with roles in the community.
Screenshot 2024-12-18 at 8 03 49 PM
  1. Questions to Address:

    • Should we continue handling roles (Admin, Moderator, Member) at the address level?
    • Is it acceptable for the same user to appear multiple times in the table with different addresses?
    • Allow the selection of a specific address in a modal (popup) but omit the address in the main table.
  2. Decision Needed:

    • Should we keep the roles at the address level or migrate them to the user level?
    • Should the new table allow duplication of the same user with different addresses, or should we consolidate this information?

@timolegros
Copy link
Collaborator

Should we keep the roles at the address level or migrate them to the user level?

The platform answer (backend/DB) is that yes we should (keep roles on Addresses). Addresses represent membership in a community. Adding roles on user model means we would need to have an array of community ids the user is an admin/moderator of and this array would not have a foreign key constraint to the Communities table.

As for how it is displayed, I leave that to @dillchen.

@dillchen
Copy link
Contributor Author

dillchen commented Dec 18, 2024

Should the new table allow duplication of the same user with different addresses, or should we consolidate this information?

We should merge the display for a User, they should only show up once within the table, they may have multiple addresses that each address should show up once then from there, we should all the roles that the user's addresses have Admin | Mod | Other Group Roles

how all address compressed like this, and then from there adjust 2 things:

  1. How Roles are Grouped -- proposal to show Role Name Dot Short Address
image
  1. How Onchain Permissions are managed

-- proposal to show a row of Role Name Dot Short Address for each potential role held within the modal

image

@salman-neslit
Copy link
Collaborator

@dillchen So regarding the display on the table we can like display multiple addresses against the user like this

Screenshot 2025-01-13 at 11 55 43 PM

But when it comes to assigning the role to an address how would it look like

Screenshot 2025-01-13 at 11 58 33 PM

how the address is assigned to the role here.

@dillchen
Copy link
Contributor Author

Per message

How Onchain Permissions are managed
-- proposal to show a row of Role Name Dot Short Address for each potential role held within the modal

Example if user has two addresses and two possible roles

Show
[address A * role A]
[address A * role B]
[address B * role A]
[address B * role B]

probably best to divide this into something with sections

So

Addresss A

  • role A
  • Role b

Address B

  • role a
  • role b

@salman-neslit salman-neslit added 3 Full day task and removed needs estimate labels Jan 13, 2025
@salman-neslit
Copy link
Collaborator

salman-neslit commented Jan 14, 2025

@dillchen is this correct?

Screenshot 2025-01-14 at 5 53 04 AM

@dillchen dillchen added the upcoming-release Should be included in the upcoming release label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Full day task enhancement New feature or request refinement upcoming-release Should be included in the upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants