Error with Object.Freeze() in IE 11

[christopherpickering]

Hi, Thanks for the plugin!

When my site is run in IE 11 there is an error with the "object.freeze()". Do you know a workaround I can put in? Thanks!

[joshgoebel]

If I float a fix are you capable of building a new distributable locally to test?

I’m guessing this is the issue:

salesforce/akita@8a63065
brandonroberts/ngrx-store-freeze#7

Technically we don’t support IE11 any more but my intention was to try and not break it until 10.0 (which is likely the next release) and then officially end support.

[christopherpickering]

Sure I can give it a shot! Thanks! Thanks, Christopher

…

On Dec 11, 2019, at 6:52 PM, Josh Goebel ***@***.***> wrote:  If I float a fix are you capable of building a new distributable locally to test? I’m guessing this is the issue: ***@***.*** brandonroberts/ngrx-store-freeze#7 Technically we don’t support IE11 any more but my intention was to try and not break it until 10.0 and then officially end support, which is likely the next release. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[joshgoebel]

Build a new version against #2319 and test please.

[christopherpickering]

Thanks, I built and tested, but still get the same error. I think the function Object.freeze(o); just doesn't exist in IE 11.

If this section of the code is removed it still works well (not sure what else is affected!) but in my app its cool.. maybe performance is slightly affected? I'm using highlight.js for a handful of sql code blocks.

If you have another idea I'd appreciate it! - otherwise I can use the code w/ this block commented out. (lines 1130 - 1151 in src/highlight.js)

[joshgoebel]

Freeze exists. The error is telling you that much.

Could you add some logging and console.log both the object and property right before freeze is called and let me know which item or property it’s blowing up on?

Commenting it out will probably work as a quick fix. This code prevents language plugins from corrupting the parser itself by modifying the shared regexes - which it turns out our own languages were doing in the past (by accident).

[christopherpickering]

Good point 👍

Yes - here's a few few pics. It seems to be because the first object is a string, not an "object" -

To test out, I changed the order of the object array to put one of the "objects" first to see if the function would successfully complete. It fails in my console.log at the freeze check with the object error, but should not hit this at runtime because the first conditions are true.

Here is rerun with the console.log removed from that section:
Now it works until it gets to a string in the array.

What do you think?

[christopherpickering]

btw, I apologize for using ie 11 😭 my personal feeling is that IE does not qualify as a browser 😄

[joshgoebel]

In ES5, if the argument to this method is not an object (a primitive), then it will cause a TypeError. In ES2015, a non-object argument will be treated as if it were a frozen ordinary object, and be simply returned.

Ah. Can you try the PR again? I modified it so we don't try to freeze any of the strings now.

[joshgoebel]

btw, I apologize for using ie 11

No problem. I appreciate your reporting this. My intention was always for 9.x to be a stable release series that people could continue to use for a while if they needed support for IE11 and older browsers while 10.0 moves on to newer things. So I'd def like to see this fixed if we can. :)

But we don't actively test new changes in IE11.

[christopherpickering]

Thanks, that works very well. I appreciate it!

[joshgoebel]

Releasing 9.17.1 with the fix.