Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented breaking change in 11.0: location of themes changed #3266

Closed
bakkot opened this issue Jul 7, 2021 · 2 comments
Closed

Undocumented breaking change in 11.0: location of themes changed #3266

bakkot opened this issue Jul 7, 2021 · 2 comments
Labels
bug help welcome Could use help from community parser

Comments

@bakkot
Copy link

bakkot commented Jul 7, 2021

#3139 moved the directories of some themes. Since the recommended way to include a theme is by adding it by path as in https://cdnjs.cloudflare.com/ajax/libs/highlight.js/10.5.0/styles/solarized-light.min.css, that means that simply bumping the version number will give you a 404 (the correct URL is now https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.0.1/styles/base16/solarized-light.min.css - note the addition of base16). This should probably be noted in the upgrade guide.
@bakkot bakkot added bug help welcome Could use help from community parser labels Jul 7, 2021
@bakkot bakkot mentioned this issue Jul 7, 2021
Merged
@joshgoebel
Copy link
Member

Closed via ca331e9

@joshgoebel
Copy link
Member

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help welcome Could use help from community parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshgoebel @bakkot