Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(request org repo) highlightjs-liquid #4173

Closed
8 of 9 tasks
laurelthorburn opened this issue Nov 25, 2024 · 4 comments
Closed
8 of 9 tasks

(request org repo) highlightjs-liquid #4173

laurelthorburn opened this issue Nov 25, 2024 · 4 comments
Assignees
Labels

Comments

@laurelthorburn
Copy link
Contributor

laurelthorburn commented Nov 25, 2024

I would like to request the creation of a highlightjs-liquid repository for my 3rd party grammar.

  • I have an existing personal repository ready to go

Metadata

Requirements

  • I've read the language Contributor Checklist
  • I've read the Language Contribution Guide
  • I'm currently willing to support and maintain this grammar over time
  • That repo includes a dist folder with CDN-ready CJS and ESM builds
  • That README.md includes examples of simple web usage
  • That README.md includes examples of Node.js usage

Afterwards

note: assuming i do this after the liquid repo has been created?

Submit a PR that:

@joshgoebel
Copy link
Member

That repo includes a dist folder with CDN-ready CJS and ESM builds

I'm not seeing the dist folder in your repository.

@laurelthorburn
Copy link
Contributor Author

laurelthorburn commented Nov 27, 2024

That repo includes a dist folder with CDN-ready CJS and ESM builds

I'm not seeing the dist folder in your repository.

It's there on my local, let me see why it didn't push.

edit to add: suspect git ignore is preventing it.. fixing now

@laurelthorburn
Copy link
Contributor Author

That repo includes a dist folder with CDN-ready CJS and ESM builds

I'm not seeing the dist folder in your repository.

@joshgoebel Yep, git ignore auto removed dist. Fixed:

https://github.com/laurelthorburn/liquid/tree/main/dist

@joshgoebel joshgoebel changed the title (request org repo) highlightjs-[name of your grammar] (request org repo) highlightjs-liquid Nov 29, 2024
@joshgoebel
Copy link
Member

Done. https://github.com/highlightjs/highlightjs-liquid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants