Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom args in hikari.internal.ux.print_banner #1006

Closed
1 task done
zunda-arrow opened this issue Feb 5, 2022 · 0 comments · Fixed by #1022
Closed
1 task done

Allow custom args in hikari.internal.ux.print_banner #1006

zunda-arrow opened this issue Feb 5, 2022 · 0 comments · Fixed by #1022
Labels
enhancement New feature or request

Comments

@zunda-arrow
Copy link
Contributor

zunda-arrow commented Feb 5, 2022

Summary

Allow any args dict to be used in hikari.internal.ux.print_banner

Why is this needed?

It is difficult to add extra information that changes to the banner. For example, a version number. Allowing custom args to be passed in would make this extremely easy,

Ideal implementation

I think the a kwarg should be added.

async def print_banner(package, allow_color, force_color, args=None):
    if args is None:
       # Set args to the current version

Updating args may also work

async def print_banner(package, allow_color, force_color, custom_args=None):
    args = {...}    
    if custom_args:
        args.update(custom_args)

Checklist

  • I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant