Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multipart responses to the interaction server #1048

Merged

Conversation

FasterSpeeding
Copy link
Collaborator

@FasterSpeeding FasterSpeeding commented Mar 2, 2022

Summary

Opening this as a draft just to keep track of it somewhere since this responses over 150 KiB seem to be automatically failed/rejected so...

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@FasterSpeeding FasterSpeeding force-pushed the task/rest-i-attachments branch from f7f3bcf to d60f775 Compare March 11, 2022 12:46
@FasterSpeeding FasterSpeeding force-pushed the task/rest-i-attachments branch from d60f775 to 4f024ef Compare March 11, 2022 16:03
@FasterSpeeding FasterSpeeding marked this pull request as ready for review March 12, 2022 12:24
@FasterSpeeding FasterSpeeding requested a review from davfsa March 27, 2022 00:00
davfsa
davfsa previously approved these changes Mar 28, 2022
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment, everything else LTGM

hikari/impl/interaction_server.py Outdated Show resolved Hide resolved
@FasterSpeeding FasterSpeeding enabled auto-merge (squash) March 30, 2022 05:58
@FasterSpeeding FasterSpeeding merged commit 9486eab into hikari-py:master Mar 30, 2022
@FasterSpeeding FasterSpeeding deleted the task/rest-i-attachments branch March 30, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants