Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch UnrecognisedEntityErrors in rest list methods #1337

Merged
merged 9 commits into from
Nov 6, 2022
Merged

Catch UnrecognisedEntityErrors in rest list methods #1337

merged 9 commits into from
Nov 6, 2022

Conversation

FasterSpeeding
Copy link
Collaborator

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

davfsa
davfsa reviewed Oct 28, 2022
View reviewed changes
hikari/impl/rest.py Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
hikari/internal/data_binding.py Outdated Show resolved Hide resolved
hikari/internal/data_binding.py Outdated Show resolved Hide resolved
hikari/internal/data_binding.py Outdated Show resolved Hide resolved
@davfsa davfsa added the bug Something isn't working label Oct 28, 2022
@davfsa davfsa merged commit 2f35ae0 into hikari-py:master Nov 6, 2022
@FasterSpeeding FasterSpeeding deleted the bugfix/handle-unknown-types-on-rest branch November 13, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FasterSpeeding @davfsa