Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guild member flag #2004

Merged
merged 16 commits into from
Aug 10, 2024
Merged

Add guild member flag #2004

merged 16 commits into from
Aug 10, 2024

Conversation

syncblaze
Copy link
Contributor

@syncblaze syncblaze commented Aug 5, 2024 •
edited
Loading

Summary

I've looked through the Discord Docs and found that the Member class has (or is supposed to have) a flags field.
This is what i decided to add.

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@syncblaze syncblaze changed the title Feature/add guild member flag Bugfix/add guild member flag Aug 5, 2024
davfsa
davfsa requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pr! Thanks!

Could you also modify tests in test/hikari/impl/entity_factory to ensure that it gets deserialized properly?

hikari/guilds.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
davfsa
davfsa reviewed Aug 6, 2024
View reviewed changes
changes/2004.bugfix.md Outdated Show resolved Hide resolved
syncblaze and others added 3 commits August 6, 2024 11:02
@syncblaze @davfsa
Update changes/2004.bugfix.md
58c8f80 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
3f346b4 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
4b25529 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze
Copy link
Contributor Author

Great pr! Thanks!

Could you also modify tests in test/hikari/impl/entity_factory to ensure that it gets deserialized properly?

sure will do that asap

@davfsa davfsa changed the title Bugfix/add guild member flag Add guild member flag Aug 6, 2024
@davfsa davfsa added the enhancement New feature or request label Aug 6, 2024
@syncblaze
Copy link
Contributor Author

Is anything missing / wrong with the PR? Is there anything to do? Or is it finished and can be merged

davfsa
davfsa reviewed Aug 7, 2024
View reviewed changes
tests/hikari/impl/test_entity_factory.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_entity_factory.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_cache.py Outdated Show resolved Hide resolved
tests/hikari/impl/test_cache.py Outdated Show resolved Hide resolved
hikari/guilds.py Outdated Show resolved Hide resolved
changes/2004.bugfix.md Outdated Show resolved Hide resolved
syncblaze and others added 7 commits August 7, 2024 10:02
@syncblaze @davfsa
Update tests/hikari/impl/test_entity_factory.py
6e62d4c 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update tests/hikari/impl/test_entity_factory.py
b49e992 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update tests/hikari/impl/test_cache.py
94a64c1 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update tests/hikari/impl/test_cache.py
8ae0f6d 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update hikari/guilds.py
3d90638 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze @davfsa
Update changes/2004.bugfix.md
bb47776 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: Blaze <[email protected]>
@syncblaze
rename changelog
764b7ad
@davfsa davfsa merged commit e4eef3d into hikari-py:master Aug 10, 2024
24 checks passed
@syncblaze syncblaze deleted the feature/add-guild-member_flag branch August 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syncblaze @davfsa