Add audit log reason to channel deletion #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added the changelog fragment, but unsure what to do about the failing tests on unix and macOS - can't reproduce these on my Windows machine, and from what I can tell based on the reported error, the failure has nothing to do with my code changes |
|
Hey! Thanks for the pull request! The test failures are completely unrelated to this PR. They seem to arise from a change downstream in aiohttp. I will fix them shortly and then get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the optional
reasonargument for the audit log tohikari.api.rest.RESTClient.delete_channelandhikari.impl.rest.RESTClientImpl.delete_channel, the same way it already exists for e.g.edit_channelChecklist
noxand all the pipelines have passed.Related issues
n/a, I brought this up on Discord earlier today and proceeded to fix it, as I was told it was likely an oversight