Improve typing for messages and message update methods #783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to @Le0Developer for bringing up the initial issue of
is_webhook
always beingTrue
forMessageUpdateEvent
in the Discord server.This had me investigate and opened up a whole can of worms where I found inconsistencies and bugs in code and documentation fixes.
Changes
typing.Optional
whereundefined.UndefinedOr
should have been used.guild_id
from the cached channel onPartialMessage
guild_id
is_webhook
can now returnundefined.UNDEFINED
if the information is not availableis_human
to account for the changes in typesPartialMessage.member
toundefined.UNDEFINED
when Discord edit the message to display an embed/attachmentChecklist
nox
and all the pipelines have passed.Related issues
None