Role Icons #838
Merged
Role Icons #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
requested review from
FasterSpeeding and
davfsa
and removed request for
FasterSpeeding
davfsa
requested changes
Oct 9, 2021
Co-authored-by: davfsa <[email protected]>
davfsa
reviewed
Oct 9, 2021
davfsa
previously requested changes
Oct 10, 2021
Co-authored-by: davfsa <[email protected]>
Co-authored-by: davfsa <[email protected]>
davfsa
reviewed
Oct 10, 2021
FasterSpeeding
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a
make_icon_urlmethod to theRoleclass and also adds the ability to create and edit roles with icons. Note that role icons only work in level 2 boosted servers.Checklist
noxand all the pipelines have passed.