Fix some bugs in message deserialization #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
force-pushed
the
task/fix-message-deserialize
branch
from
a337a2f to
c575b5f
Compare
davfsa
commented
Dec 20, 2021
davfsa
force-pushed
the
task/fix-message-deserialize
branch
from
c575b5f to
11a27d1
Compare
- Remove case for setting member to undefined.Undefined in full message deserialization - Don't set member to undefined.UNDEFINED on partial message if message was sent by a webhook
davfsa
force-pushed
the
task/fix-message-deserialize
branch
from
11a27d1 to
31aa059
Compare
FasterSpeeding
approved these changes
Dec 31, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
noxand all the pipelines have passed.