refactor: not use reserved keyword package

slipnbytes · Mar 15, 2021 · 0fc902f · 0fc902f
1 parent b5af7e8
commit 0fc902f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -5,8 +5,10 @@ const { ROOT_PATH } = require('./shared/constants');
 const { getWorkspacesPackages } = require('./shared/getWorkspacesPackages');
 
 const projects = getWorkspacesPackages(false)
-  .filter(package => existsSync(join(ROOT_PATH, package, 'jest.config.js')))
-  .map(package => `<rootDir>/${package}/jest.config.js`);
+  .filter(packageName =>
+    existsSync(join(ROOT_PATH, packageName, 'jest.config.js')),
+  )
+  .map(packageName => `<rootDir>/${packageName}/jest.config.js`);
 
 module.exports = {
   projects,

diff --git a/scripts/test-all.js b/scripts/test-all.js
@@ -7,8 +7,8 @@ const { getWorkspacesPackages } = require('../shared/getWorkspacesPackages');
 const packages = getWorkspacesPackages();
 
 async function testAll() {
-  for await (const package of packages) {
-    const cwd = join(ROOT_PATH, package);
+  for await (const packageName of packages) {
+    const cwd = join(ROOT_PATH, packageName);
 
     await exec('yarn jest --passWithNoTests', cwd);
   }

diff --git a/shared/getWorkspacesPackages.js b/shared/getWorkspacesPackages.js
@@ -43,15 +43,15 @@ function isDirectory(path) {
 
 /**
  * @param {string} workspace
- * @param {string} package
+ * @param {string} packageName
  * @return {string}
  */
-function makePackagePath(workspace, package) {
+function makePackagePath(workspace, packageName) {
   if (['', '/'].includes(workspace)) {
-    return package;
+    return packageName;
   }
 
-  return `${workspace}/${package}`;
+  return `${workspace}/${packageName}`;
 }
 
 /**
@@ -73,8 +73,8 @@ function getPackages(workspace) {
   const mappedPackages = readdirSync(path);
 
   return mappedPackages
-    .filter(package => isDirectory(join(path, package)))
-    .map(package => makePackagePath(workspaceCleaned, package));
+    .filter(packageName => isDirectory(join(path, packageName)))
+    .map(packageName => makePackagePath(workspaceCleaned, packageName));
 }
 
 module.exports = {