Skip to content
This repository has been archived by the owner on Sep 15, 2020. It is now read-only.

test and fix errors in gossip propigation #429

Closed
zippy opened this issue Sep 29, 2017 · 3 comments
Closed

test and fix errors in gossip propigation #429

zippy opened this issue Sep 29, 2017 · 3 comments
Assignees
Milestone

Comments

@zippy
Copy link
Member

zippy commented Sep 29, 2017

currently TestGossipPropigation is disabled because in some instances the propigation doesn't fully complete, i.e. it doesn't get to every single node in the ring. We need to figure out why, and test lots of other network connection topologies.

@zippy zippy added this to the Alpha 0 milestone Sep 29, 2017
@zippy zippy added the Sprint label Sep 29, 2017
@zippy
Copy link
Member Author

zippy commented Oct 18, 2017

A big part of this turns out to be a bug in libp2p, however, at high volume of gossip, there seems to be some other problems..

@zippy zippy added in progress and removed Sprint labels Oct 23, 2017
@zippy zippy self-assigned this Oct 23, 2017
@zippy zippy changed the title pound on gossip propigation test and fix errors in gossip propigation Oct 23, 2017
@zippy zippy modified the milestones: Alpha 0, Alpha 1 Oct 23, 2017
@zippy
Copy link
Member Author

zippy commented Oct 23, 2017

The issues in the gossip propagation tests seem to be due to deeper issues is the DHT model. The failures to propigate don't come from the gossip as much as coming from failures in initial sending to the DHT that happen. For example it seems like in clutter there are some commits that happen during genesis that aren't always getting put to the DHT (perhaps because at the time of genesis those nodes don't have anything in their routing table?). So this ticket is really about adding more tests to prove this, or wait until we update the DHT model to take into account the startup phase.

@zippy zippy added backlog and removed in progress labels Oct 23, 2017
@zippy zippy added Sprint and removed backlog labels Nov 4, 2017
@lucksus lucksus added backlog and removed Sprint labels Nov 13, 2017
@zippy
Copy link
Member Author

zippy commented Feb 27, 2018

After much analysis, we realize that the issue is really that gossip needs to not be about entries but about nodes. Thus this ticket is thus now superceeded by #582

@zippy zippy closed this as completed Feb 27, 2018
@zippy zippy removed the backlog label Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants