Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holoviews plots not appearing in Internet Explorer #3103

Closed
Forander opened this issue Oct 24, 2018 · 7 comments
Closed

Holoviews plots not appearing in Internet Explorer #3103

Forander opened this issue Oct 24, 2018 · 7 comments

Comments

@Forander
Copy link

Hi,

my Holoviews plots are not appearing when opening a Jupyter Notebook saved HTML in Internet Explorer (works with Firefox and Chrome). I am using holoviews 1.10.7, IE 11 and Windows 7.

Does anyone have any experience trying to resolve this issue?

Thanks.

@Forander Forander changed the title HTML plots not appearing in Internet Explorer Holoviews plots not appearing in Internet Explorer Oct 24, 2018
@philippjfr
Copy link
Member

Any chance you could look at the browser's development console and see if there are any errors?

@xavArtley
Copy link

xavArtley commented Oct 25, 2018

https://docs.microsoft.com/en-us/scripting/javascript/misc/invalid-character-javascript

htmlObject.innerHTML = `<div class="hololayout row row-fluid">

// Ugly hack - see #2574 for more information
if (!(document.getElementById('4f1b21fb-3651-4edc-a8ac-aad8cf4db462')) && !(document.getElementById('_anim_img8a9e9d32019c49c6883763b1b0548086'))) {
  console.log("Creating DOM nodes dynamically for assumed nbconvert export. To generate clean HTML output set HV_DOC_HTML as an environment variable.")
  var htmlObject = document.createElement('div');
  htmlObject.innerHTML = `<div class="hololayout row row-fluid">
  <div class="holoframe" id="display_area8a9e9d32019c49c6883763b1b0548086">
    <div id="_anim_img8a9e9d32019c49c6883763b1b0548086">
      
      <div id='4f1b21fb-3651-4edc-a8ac-aad8cf4db462' style='display: table; margin: 0 auto;'>


@philippjfr
Copy link
Member

Thanks, that makes sense, template strings are not supported by older browsers. Will try to come up with a workaround.

@Forander
Copy link
Author

Forander commented Oct 25, 2018

Thanks Philipp and Xav for the replies. Yes it does seem to be the invalid character javascript error. I got a SCRIPT1014: Invalid character error in Internet Explorer console for each of my Holoviews plots.

@philippjfr
Copy link
Member

I'll try to come up with a fix and include it as part of the 1.10.8 release we're planning to get out today.

@philippjfr
Copy link
Member

Looks like the fix will have to be in pyviz_comms as that's where this error originates.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants