Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicMap callback return types should be validated #373

Closed
philippjfr opened this issue Dec 20, 2015 · 2 comments
Closed

DynamicMap callback return types should be validated #373

philippjfr opened this issue Dec 20, 2015 · 2 comments

Comments

@philippjfr
Copy link
Member

When working with DynamicMaps and returning Overlays it is possible that the keys in the Overlay can change, which makes it necessary to reassign the Element to a matching plot instance. Reassigning plots in this way will work when PR #367 is merged but since no global ordering can be computed during initialization of the plot it's not possible to assign the correct cyclic index in this case. We should detect this condition in the plotting code and warn about it, which should then alert the user by displaying the warning in the browser (https://github.com/ioam/holoviews/issues/372).

Additionally we should validate the type and number of returned Elements in an Overlay and warn the user if one or more types could not be rendered because they were not declared during initialization.

@philippjfr philippjfr changed the title DynamicMaps should be validated for cyclic styles DynamicMaps return types should be validated Dec 20, 2015
@philippjfr philippjfr changed the title DynamicMaps return types should be validated DynamicMap callback return types should be validated Dec 20, 2015
@philippjfr
Copy link
Member Author

This issue is no longer relevant since the underlying restriction has been addressed.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant