From b546d63a1a8d928ab6f2485629e20a184a41e16f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20H=C3=B8xbro=20Hansen?= <simon.hansen@me.com>
Date: Sat, 28 Sep 2024 10:15:05 +0200
Subject: [PATCH 1/2] ci: Add collector to avoid if statements

---
 .github/workflows/test.yaml | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 6f2db511bd..ed4e8110c4 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -115,29 +115,25 @@ jobs:
     name: unit:${{ matrix.environment }}:${{ matrix.os }}
     needs: [pre_commit, setup, pixi_lock]
     runs-on: ${{ matrix.os }}
+    if: needs.setup.outputs.code_change == 'true'
     strategy:
       fail-fast: false
       matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
     timeout-minutes: 120
     steps:
       - uses: holoviz-dev/holoviz_tasks/pixi_install@v0
-        if: needs.setup.outputs.code_change == 'true'
         with:
           environments: ${{ matrix.environment }}
       - name: Check packages latest version
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           pixi run -e ${{ matrix.environment }} check-latest-packages bokeh panel param datashader
       - name: Test Unit
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           pixi run -e ${{ matrix.environment }} test-unit $COV
       - name: Test Examples
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           pixi run -e ${{ matrix.environment }} test-example
       - uses: codecov/codecov-action@v4
-        if: needs.setup.outputs.code_change == 'true'
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 
@@ -145,6 +141,7 @@ jobs:
     name: ui:${{ matrix.environment }}:${{ matrix.os }}
     needs: [pre_commit, setup, pixi_lock]
     runs-on: ${{ matrix.os }}
+    if: needs.setup.outputs.code_change == 'true'
     strategy:
       fail-fast: false
       matrix:
@@ -155,11 +152,9 @@ jobs:
       PANEL_LOG_LEVEL: info
     steps:
       - uses: holoviz-dev/holoviz_tasks/pixi_install@v0
-        if: needs.setup.outputs.code_change == 'true'
         with:
           environments: ${{ matrix.environment }}
       - name: Test UI
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           # Create a .uicoveragerc file to set the concurrency library to greenlet
           # https://github.com/microsoft/playwright-python/issues/313
@@ -173,7 +168,6 @@ jobs:
           path: ./ui_screenshots
           if-no-files-found: ignore
       - uses: codecov/codecov-action@v4
-        if: needs.setup.outputs.code_change == 'true'
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 
@@ -181,6 +175,7 @@ jobs:
     name: core:${{ matrix.environment }}:${{ matrix.os }}
     needs: [pre_commit, setup, pixi_lock]
     runs-on: ${{ matrix.os }}
+    if: needs.setup.outputs.code_change == 'true'
     strategy:
       fail-fast: false
       matrix:
@@ -189,14 +184,20 @@ jobs:
     timeout-minutes: 120
     steps:
       - uses: holoviz-dev/holoviz_tasks/pixi_install@v0
-        if: needs.setup.outputs.code_change == 'true'
         with:
           environments: ${{ matrix.environment }}
       - name: Check packages latest version
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           pixi run -e ${{ matrix.environment }} check-latest-packages numpy pandas bokeh panel param
       - name: Test Unit
-        if: needs.setup.outputs.code_change == 'true'
         run: |
           pixi run -e ${{ matrix.environment }} test-unit
+
+  result_test_suite:
+    needs: [unit_test_suite, ui_test_suite, core_test_suite]
+    if: always()
+    runs-on: ubuntu-latest
+    steps:
+      - name: check for failures
+        if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
+        run: echo job failed && exit 1

From a4197fdd83164184882772a214ba22d082767a1e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20H=C3=B8xbro=20Hansen?= <simon.hansen@me.com>
Date: Sat, 28 Sep 2024 11:50:46 +0200
Subject: [PATCH 2/2] Update name

---
 .github/workflows/test.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index ed4e8110c4..60f10bec82 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -194,6 +194,7 @@ jobs:
           pixi run -e ${{ matrix.environment }} test-unit
 
   result_test_suite:
+    name: result:test
     needs: [unit_test_suite, ui_test_suite, core_test_suite]
     if: always()
     runs-on: ubuntu-latest