Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serving static dirs --- missing argument #1491

Closed
nghenzi opened this issue Jul 22, 2020 · 3 comments
Closed

serving static dirs --- missing argument #1491

nghenzi opened this issue Jul 22, 2020 · 3 comments
Milestone

Comments

@nghenzi
Copy link
Contributor

nghenzi commented Jul 22, 2020

ALL software version info

(this library, plus any other relevant software, e.g. bokeh, python, notebook, OS, browser, etc)

Name Version Build Channel

panel 0.10.0a16.post5+gc028511 dev_0

Description of expected behavior and the observed behavior

I am serving some javascript static files with the static-dirs option in a panel dev environment. It appears an error of missing argument.

image

After that I was looking for the error and I believe that the errors is in the line 104 of panel/command/serve.py.

There it should be "patterns += get_static_routes(static_dirs) " instead of "patterns += get_static_routes()".

After I corrected that, I had to change the directory path of the line 103 in the same file. I hardcoded it to the location of the dist folder.

I think the error appears in this pull request

#1472 Fix issues with requirejs and templates

@philippjfr
Copy link
Member

Thanks, clearly a bug. A PR would be very welcome.

@philippjfr philippjfr added this to the v0.10.0 milestone Jul 22, 2020
@nghenzi
Copy link
Contributor Author

nghenzi commented Jul 22, 2020

done. I think it's ok, but I don't have much experience on this.

@philippjfr
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants