Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FileSelector file icon on selected files #2046

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2044

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2046 (e40b2db) into master (20617c8) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   84.30%   83.95%   -0.36%     
==========================================
  Files         178      178              
  Lines       20612    20189     -423     
==========================================
- Hits        17377    16949     -428     
- Misses       3235     3240       +5     
Impacted Files Coverage Δ
panel/widgets/file_selector.py 85.09% <0.00%> (ø)
panel/tests/pane/test_base.py 87.09% <0.00%> (-12.91%) ⬇️
panel/config.py 46.15% <0.00%> (-5.79%) ⬇️
panel/auth.py 36.51% <0.00%> (-3.37%) ⬇️
panel/pane/ipywidget.py 47.05% <0.00%> (-2.95%) ⬇️
panel/io/reload.py 63.95% <0.00%> (-2.72%) ⬇️
panel/io/callbacks.py 54.16% <0.00%> (-2.42%) ⬇️
panel/tests/template/test_manual.py 60.63% <0.00%> (-2.37%) ⬇️
panel/io/state.py 58.42% <0.00%> (-2.28%) ⬇️
panel/pane/plot.py 54.33% <0.00%> (-2.26%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20617c8...e40b2db. Read the comment docs.

@philippjfr philippjfr merged commit 483f8c3 into master Mar 2, 2021
@philippjfr philippjfr deleted the file_selector_file_icon branch March 2, 2021 13:00
@dhruvbalwada dhruvbalwada mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSelector widgets adds folder icon to files
1 participant