Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of template resources from relative paths #2067

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2066

@philippjfr
Copy link
Member Author

@xavArtley Do you know what this error is about?

ValueError: VTKVolume pane does not support objects of type 'UniformGrid'.

@xavArtley
Copy link
Collaborator

May be but I don't understand the link with this issue

@philippjfr
Copy link
Member Author

There isn't one, all PRs are currently failing due to this error.

@xavArtley
Copy link
Collaborator

May be a change in pyvista version?

@xavArtley
Copy link
Collaborator

It's strange I installed latest pyvista version but it should not raise error
image

@xavArtley
Copy link
Collaborator

xavArtley commented Mar 10, 2021

I think it's indirectly related to pyvista
the VTKVolume.applies test if vtk is in sys.module
I suppose vtk was imported when pyvista was but now it is not imported anymore and VTKVolume.applies return False

@philippjfr philippjfr force-pushed the fix_template_load_path branch from 924395a to d77f477 Compare March 10, 2021 15:30
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2067 (d77f477) into master (8a233ca) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   84.43%   84.39%   -0.04%     
==========================================
  Files         178      178              
  Lines       20636    20636              
==========================================
- Hits        17423    17415       -8     
- Misses       3213     3221       +8     
Impacted Files Coverage Δ
panel/template/base.py 79.85% <100.00%> (ø)
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/base.py 90.61% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a233ca...d77f477. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment of Templated Apps to Binder using jupypter-panel-proxy not working.
2 participants