Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating of selection property #2128

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fix updating of selection property #2128

merged 1 commit into from
Mar 29, 2021

Conversation

philippjfr
Copy link
Member

Could not reset the selection in a callback since the _updating check prevented changes.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #2128 (51a6d81) into master (43de0fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
- Coverage   84.27%   84.24%   -0.03%     
==========================================
  Files         182      182              
  Lines       21415    21413       -2     
==========================================
- Hits        18047    18040       -7     
- Misses       3368     3373       +5     
Impacted Files Coverage Δ
panel/reactive.py 77.30% <ø> (+0.08%) ⬆️
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/pane/base.py 87.89% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43de0fa...51a6d81. Read the comment docs.

@philippjfr philippjfr merged commit 1c3e4b3 into master Mar 29, 2021
@philippjfr philippjfr deleted the selection_prop branch March 29, 2021 15:24
philippjfr added a commit that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant