Ensure changes on ReactiveData source are scheduled correctly #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Mar 31, 2021
philippjfr
force-pushed
the
reactive_data_apply_changes
branch
from
fb15248 to
ede085c
Compare
philippjfr
force-pushed
the
reactive_data_apply_changes
branch
from
628d196 to
16094b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2134 +/- ##
==========================================
- Coverage 83.81% 83.77% -0.04%
==========================================
Files 182 182
Lines 21643 21646 +3
==========================================
- Hits 18139 18135 -4
- Misses 3504 3511 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should never have applied model changes directly. This PR ensures all model changes are correctly scheduled.
Fixes #2116