Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic JupyterLab theme support #2848

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Add basic JupyterLab theme support #2848

merged 2 commits into from
Oct 21, 2021

Conversation

philippjfr
Copy link
Member

Ensures that at least the text follows the JupyterLab theme ensuring it is visible in dark mode.

Screen Shot 2021-10-21 at 5 41 01 PM

Fixes #520

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2848 (2fef938) into master (1a334dc) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2848   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         188      188           
  Lines       24450    24452    +2     
=======================================
+ Hits        20307    20309    +2     
  Misses       4143     4143           
Impacted Files Coverage Δ
panel/io/notebook.py 52.55% <33.33%> (-0.55%) ⬇️
panel/tests/command/test_serve.py 85.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a334dc...2fef938. Read the comment docs.

@philippjfr philippjfr merged commit 0c0c4ba into master Oct 21, 2021
@philippjfr philippjfr deleted the jlab_theme branch October 21, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel labels do not follow jupyterlab theme
1 participant