Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Plotly styling gallery notebook #3038

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Adds Plotly styling gallery notebook #3038

merged 5 commits into from
Jan 24, 2022

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 23, 2021

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #3038 (3eb4772) into master (09bab95) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
- Coverage   83.25%   82.99%   -0.27%     
==========================================
  Files         190      192       +2     
  Lines       24971    25477     +506     
==========================================
+ Hits        20789    21144     +355     
- Misses       4182     4333     +151     
Impacted Files Coverage Δ
panel/models/tabulator.py 95.45% <0.00%> (-3.18%) ⬇️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️
panel/io/server.py 71.94% <0.00%> (-1.70%) ⬇️
panel/tests/conftest.py 94.85% <0.00%> (-1.05%) ⬇️
panel/auth.py 39.94% <0.00%> (-0.68%) ⬇️
panel/tests/pane/test_plotly.py 98.15% <0.00%> (-0.62%) ⬇️
panel/widgets/tables.py 84.97% <0.00%> (-0.58%) ⬇️
panel/command/serve.py 39.26% <0.00%> (-0.31%) ⬇️
panel/pane/vega.py 83.04% <0.00%> (-0.30%) ⬇️
panel/template/base.py 78.43% <0.00%> (-0.28%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bab95...3eb4772. Read the comment docs.

@philippjfr
Copy link
Member

Thanks for these PRs. I'd like to avoid merging 2 MB+ images into the repo and am open to suggestions. Would be happy to put them in an S3 bucket for you but if you have an alternative self-service solution I'd love to hear it.

@MarcSkovMadsen
Copy link
Collaborator Author

An S3 bucket and a description in the developer guide on how to contribute assets like these would be super helpful.

Personally I just put my assets in a separate GitHub repo.

@MarcSkovMadsen
Copy link
Collaborator Author

For now I will just reference this .gif. Please upload to s3 bucket @philippjfr . Thanks

PlotlyStyle (1)

@philippjfr
Copy link
Member

Here's the link: https://assets.holoviews.org/panel/thumbnails/gallery/styles/plotly-styles.gif

Maybe I'll create a bucket specifically for Panel one of these days but not today.

@philippjfr philippjfr merged commit d914aee into master Jan 24, 2022
@philippjfr philippjfr deleted the plotly-styling branch January 24, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants