Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending messages on closed or closing Websocket #3115

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3113

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #3115 (576eba8) into master (77882db) will decrease coverage by 0.02%.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   83.10%   83.07%   -0.03%     
==========================================
  Files         192      192              
  Lines       25460    25463       +3     
==========================================
- Hits        21159    21154       -5     
- Misses       4301     4309       +8     
Impacted Files Coverage Δ
panel/io/server.py 71.94% <0.00%> (-0.93%) ⬇️
panel/reactive.py 76.28% <ø> (-0.06%) ⬇️
panel/io/state.py 69.18% <100.00%> (-0.11%) ⬇️
panel/io/reload.py 69.23% <0.00%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77882db...576eba8. Read the comment docs.

@philippjfr philippjfr merged commit 8b21f35 into master Jan 19, 2022
@philippjfr philippjfr deleted the closed_websocket_handling branch January 19, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

periodic_callback not robust. Raises exceptions when browser tab refreshed or closed.
1 participant