Ensure gc.collect is not excessively called #3259
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3259 +/- ##
=======================================
Coverage 83.14% 83.15%
=======================================
Files 195 195
Lines 26008 26021 +13
=======================================
+ Hits 21625 21638 +13
Misses 4383 4383
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bokeh will call gc.collect() on every
Document.destroy(). If you are cleaning up multiple sessions simultaneously this is excessive and can in fact lock up the server for multiple seconds. Here we overrideDocument.destroyand schedule a separate task that effectively throttles gc.collect calls.