Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Progress default value is -1 #3307

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Ensure Progress default value is -1 #3307

merged 2 commits into from
Apr 4, 2022

Conversation

philippjfr
Copy link
Member

Fixes #3166

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #3307 (9e5cb6a) into master (6895a63) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
+ Coverage   83.40%   83.41%   +0.01%     
==========================================
  Files         196      196              
  Lines       26495    26502       +7     
==========================================
+ Hits        22097    22106       +9     
+ Misses       4398     4396       -2     
Impacted Files Coverage Δ
panel/widgets/indicators.py 92.48% <100.00%> (+0.33%) ⬆️
panel/widgets/tables.py 87.88% <0.00%> (-0.04%) ⬇️
panel/reactive.py 77.60% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6895a63...9e5cb6a. Read the comment docs.

@philippjfr philippjfr merged commit cd32491 into master Apr 4, 2022
@philippjfr philippjfr deleted the progress_default branch April 4, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress should default value=-1 (on master) or raise a warning
1 participant