Added jscallback method to Viewable objects #665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While jslink is very convenient for linking two objects it is also limited because it only exposes the source and target object, doesn't allow providing just a callback on the source and is not really designed around providing custom code.
This PR introduces a
.jscallback
method which can be used to add arbitrary JS callbacks, e.g. this example takes the values of the two slider and triggers an alert:Cc: @xavArtley I know you were playing around with adding
args
to links but I think this generalizes this more.links.py