You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At least up to version 1.10.1, get_soft_bounds respects the hard bounds if there is no soft bounds, but it doesn't actually crop to the hard bounds:
defget_soft_bounds(self):
""" For each soft bound (upper and lower), if there is a defined bound (not equal to None) then it is returned, otherwise it defaults to the hard bound. The hard bound could still be None. """ifself.boundsisNone:
hl, hu= (None, None)
else:
hl, hu=self.boundsifself.softboundsisNone:
sl, su= (None, None)
else:
sl, su=self.softboundsifslisNone: l=hlelse: l=slifsuisNone: u=huelse: u=sureturn (l, u)
I think it should not only enforce the hard bounds where softbounds is None, but also crop any soft bounds provided by the hard bounds. Right now if softbounds are provided that are outside the hard bounds, get_soft_bounds will return an illegal range of values. Such a softbounds are arguably an error, but since we don't prevent that error, we should presumably deal with such a case at least here.
The text was updated successfully, but these errors were encountered:
At least up to version 1.10.1,
get_soft_bounds
respects the hard bounds if there is no soft bounds, but it doesn't actually crop to the hard bounds:I think it should not only enforce the hard bounds where
softbounds
is None, but also crop any soft bounds provided by the hard bounds. Right now ifsoftbounds
are provided that are outside the hard bounds,get_soft_bounds
will return an illegal range of values. Such asoftbounds
are arguably an error, but since we don't prevent that error, we should presumably deal with such a case at least here.The text was updated successfully, but these errors were encountered: