Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Notification Volume when using alarm_stream_max without TTS #1166

Closed
LucidityCrash opened this issue Nov 8, 2020 · 2 comments · Fixed by #1168
Closed

Increase Notification Volume when using alarm_stream_max without TTS #1166

LucidityCrash opened this issue Nov 8, 2020 · 2 comments · Fixed by #1168
Labels
enhancement New feature or request notifications

Comments

@LucidityCrash
Copy link

Currently alarm_stream_max only increases the alarm volume when using TTS, I'd have thought having this happen for simple audio notifications would also be nice.

@dshokouhi
Copy link
Member

dshokouhi commented Nov 8, 2020

So the reason why this works for TTS and not normal notifications is because for TTS we get notified when the speech starts and stops. We don't get that with a normal notification. The only way to proceed here is to introduce a command where users can adjust the volume on their own.

Edit: also what happened to the feature request template?

@LucidityCrash
Copy link
Author

Edit: also what happened to the feature request template?

sorry ... when I rased this I wasn't given an option to select "enhancement request" ... but when I click on new issue just now I get a choice of a bug or an enhancement ... very strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request notifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants