Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] questions how many windows / doors are open or closed does not work properly #1216

Open
ChristophCaina opened this issue Mar 10, 2023 · 7 comments
Labels

Comments

@ChristophCaina
Copy link

The question "how many windows | doora are open" / "how many windows | doors are closed" does always return 0... (german and english)...

image

After checking the english language repository, there are a few more files - especially "binary_sensor
image

So, do we need to replicate and translate these files?

@TheFes
Copy link
Contributor

TheFes commented Mar 13, 2023

I don't think the which, all, any and how many intents are already translated for German.
But even if they were, there is a conflict with the domain cover for device_class window and door.
Both cover and binary_sensor are using these device classes, and the you are getting the result 0 now becuase you don't have any cover entities with device_class window. These questions are now already matched to that domain.

There is currently no option to match with two domains, especially because the states also differ. A cover entity can be open or closed, where a binary_sensor will be on or off.

For more info, also see #1200

@ChristophCaina
Copy link
Author

hm... ok, that's sad.
yes... the only "cover" I do have is using the device_class "shutter"...
While I can see the "cover" in the case of doors, for example garage door covers, I don't really see it for the device class window...

So right now, there's still a LOT that needs to be considered for assist to be at least somehow usable... :)
All right.

@TheFes
Copy link
Contributor

TheFes commented Mar 13, 2023

You can motorize a window so you can open and close it remotely. I would put that in the cover domain (as there is no separate window domain)

@TheFes
Copy link
Contributor

TheFes commented Mar 13, 2023

But as you can see in the linked discussion, I proposed on short term to remove these sentences for door and window from the cover domain, and place them in the binary_sensor domain, as I expect they are more frequently used (until there is a long term solution)

@OzGav
Copy link
Contributor

OzGav commented May 6, 2023

I see a similar problem in English. Exactly the same behaviour if I use windows. This is when there are actually one door and two windows open

How can I assist?
are all the doors open
Yes
are all the doors closed
Yes
How many doors are open
0
How many doors are closed
0

@TheFes
Copy link
Contributor

TheFes commented May 6, 2023

That's because these intents check for cover entities with device class door, not for binary sensors. It's currently not possible to check for both at the same time, and cover support was added before binary_sensor support

@OzGav
Copy link
Contributor

OzGav commented May 6, 2023

OK understood. I will wait! Thanks for the speedy reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants