Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor logs warnings for add-on options that have been removed #4644

Closed
shypike opened this issue Oct 22, 2023 · 2 comments
Closed

Supervisor logs warnings for add-on options that have been removed #4644

shypike opened this issue Oct 22, 2023 · 2 comments
Labels

Comments

@shypike
Copy link

shypike commented Oct 22, 2023

Describe the issue you are experiencing

I've upgraded the OneDrive Backup add-on (https://github.com/lavinir/hassio-onedrive-backup).
The latest versions have moved the options from the standard option page to its own ingress Web-UI.
The Supervisor still remembers the now obsolete options and complains about them.
I wonder what the purpose of these warnings is because they provide no useful information and it doesn't seem that the end-user or the add-on author have any means to address the problem.
I've been trying to help the author, but I cannot even find out where the Supervisor stores its add-on configuration data.

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Steps to reproduce the issue

  1. Restart the OneDrive Backup add-on
  2. Inspect the Supervisor log

Anything in the Supervisor logs that might be useful for us?

23-10-20 16:56:42 WARNING (MainThread) [supervisor.addons.options] Option 'local_backup_num_to_keep' does not exist in the schema for OneDrive Backup (de91e161_hassio_onedrive_backup)

And many more of these.

System Health information

There are currently no repairs available

Supervisor diagnostics

config_entry-hassio-d13d6f1ec199024808a22a0f65ee035c.json.txt

Additional information

No response

@shypike shypike added the bug label Oct 22, 2023
@mdegat01
Copy link
Contributor

mdegat01 commented Oct 23, 2023

I wonder what the purpose of these warnings is because they provide no useful information and it doesn't seem that the end-user or the add-on author have any means to address the problem.

You can address these problems. Go to Settings -> Addons -> OneDrive Backup. Then go to the configuration tab. Switch to YAML mode at the top and remove any deprecated options.

The add-on dev can also fix this for you as well. For example, notice the reset_database option in the Nginx Proxy Manager community addon. The way this option works is when a user sets it to true it resets the internal DB to a blank slate. The add-on itself then removes this option from its own config for the user to prevent them from accidentally resetting their database every time it restarts. You can see how it does that here:
https://github.com/hassio-addons/addon-nginx-proxy-manager/blob/f5c53c130c6a29b8b1d5a06b80cc1c8261705b65/proxy-manager/rootfs/etc/cont-init.d/mysql.sh#L31-L32

Supervisor could remove the option since it sees that its no longer in the schema. I think the reason we don't is because then that information would be lost. If config had changed or moved somewhere else users may wish to see the previous value to know what they used to have when setting the new one. It's something to consider. In the meantime though this can be fixed by both users and add-on devs currently.

@shypike
Copy link
Author

shypike commented Oct 23, 2023

Makes perfect sense and the YAML "trick" works.
My remaining issue is that this info is very hard to find for the less experienced :)
Thank you for your clear answer; I'll notify the author too.
Please, close the issue.

@pvizeli pvizeli closed this as completed Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants