Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter-type metrics for samplers are broken #1279

Closed
kentquirk opened this issue Aug 15, 2024 · 0 comments · Fixed by #1281
Closed

Counter-type metrics for samplers are broken #1279

kentquirk opened this issue Aug 15, 2024 · 0 comments · Fixed by #1281
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@kentquirk
Copy link
Contributor

Versions

  • Refinery: all recent

Steps to reproduce

  1. Use an EMADynamic sampler (or anything that has an AdjustmentInterval)
  2. Send its metrics to Honeycomb
  3. Note that the metric count seems to increase exponentially

The problem is that Refinery is reading a counter and wanting to increment the metrics counter to get the same result -- but never records the previous value, so is just always incrementing by the value of the counter.

This is a bug in several sampler implementations. Can we centralize the code to a helper function?

Additional context
Pollinators thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant