Skip to content
This repository has been archived by the owner on Dec 21, 2020. It is now read-only.

Switch ganache-core as a devDependency #63

Closed
3 tasks done
0xjjpa opened this issue Jun 15, 2020 · 2 comments
Closed
3 tasks done

Switch ganache-core as a devDependency #63

0xjjpa opened this issue Jun 15, 2020 · 2 comments
Assignees
Milestone

Comments

@0xjjpa
Copy link
Contributor

0xjjpa commented Jun 15, 2020

  • Move ganache-core as a devDependency to avoid embedding it in hopr-core, which is making the compilation of the binary more bloated and difficult.
  • Update the required scripts that rely on this dependency to ensure a build can be created successfully w/o this particular dependency listed as a main dependency.
  • Deploy a dev version of hopr-core-ethereum with this setup; ensure it it is working by creating a new package and installing it and ensuring its not listed in the node_modules folder.

e.g.

$ mkdir test && cd test
$ test> npm init -y && npm i @hoprnet/hopr-core-ethereum
$ test> npm ls | grep ganache-core
@0xjjpa 0xjjpa added this to the Sprint 7 milestone Jun 15, 2020
@0xjjpa
Copy link
Contributor Author

0xjjpa commented Jun 15, 2020

@nionis Version 0.3.5-dev.ac4725c of hopr-ethereum already does not include ganache-core, but its currently breaking the build.

node_modules/@hoprnet/hopr-ethereum/build/lib/scripts/operations/utils/ganache.d.ts:1:21 - error TS2307: Cannot find module 'ganache-core' or its corresponding type declarations.

1 import Ganache from 'ganache-core';
                      ~~~~~~~~~~~~~~


Found 1 error.

Please update and adapt as needed.

@0xjjpa
Copy link
Contributor Author

0xjjpa commented Jun 22, 2020

Working already in hopr-core, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants