Central handling of callbacks

horstoeko · Nov 7, 2024 · ba680e6 · ba680e6
1 parent df25c32
commit ba680e6
Show file tree

Hide file tree

Showing 4 changed files with 70 additions and 69 deletions.
diff --git a/src/XmlDocumentReader.php b/src/XmlDocumentReader.php
@@ -13,6 +13,7 @@
 use DOMXPath;
 use DOMDocument;
 use DOMNodeList;
+use horstoeko\zugferdublbridge\traits\HandlesCallbacks;
 use horstoeko\zugferdublbridge\xml\XmlNodeList;
 use horstoeko\zugferdublbridge\XmlDocumentBase;
 use RuntimeException;
@@ -29,6 +30,8 @@
  */
 class XmlDocumentReader extends XmlDocumentBase
 {
+    use HandlesCallbacks;
+
     /**
      * Internal XPath
      *
@@ -223,17 +226,13 @@ public function queryAll(string $expression, ?DOMNode $contextNode = null): XmlN
     public function whenExists(string $expression, ?DOMNode $contextNode, $callback, $callbackElse = null): XmlDocumentReader
     {
         if ($this->exists($expression, $contextNode)) {
-            if (is_callable($callback)) {
-                call_user_func(
-                    $callback,
-                    $this->query($expression, $contextNode)->item(0),
-                    $this->query($expression, $contextNode)->item(0)->parentNode
-                );
-            }
+            $this->fireCallback(
+                $callback,
+                $this->query($expression, $contextNode)->item(0),
+                $this->query($expression, $contextNode)->item(0)->parentNode
+            );
         } else {
-            if (is_callable($callbackElse)) {
-                call_user_func($callbackElse);
-            }
+            $this->fireCallback($callbackElse);
         }
 
         return $this;
@@ -251,17 +250,13 @@ public function whenExists(string $expression, ?DOMNode $contextNode, $callback,
     public function whenNotExists(string $expression, ?DOMNode $contextNode, $callback, $callbackElse = null): XmlDocumentReader
     {
         if (!$this->exists($expression, $contextNode)) {
-            if (is_callable($callback)) {
-                call_user_func(
-                    $callback,
-                    $this->query($expression, $contextNode)->item(0),
-                    $this->query($expression, $contextNode)->item(0)->parentNode
-                );
-            }
+            $this->fireCallback(
+                $callback,
+                $this->query($expression, $contextNode)->item(0),
+                $this->query($expression, $contextNode)->item(0)->parentNode
+            );
         } else {
-            if (is_callable($callbackElse)) {
-                call_user_func($callbackElse);
-            }
+            $this->fireCallback($callbackElse);
         }
 
         return $this;
@@ -293,17 +288,13 @@ public function whenEquals(string $expression, ?DOMNode $contextNode, $values, $
         }
 
         if ($equals === true) {
-            if (is_callable($callback)) {
-                call_user_func(
-                    $callback,
-                    $this->query($expression, $contextNode)->item(0),
-                    $this->query($expression, $contextNode)->item(0)->parentNode
-                );
-            }
+            $this->fireCallback(
+                $callback,
+                $this->query($expression, $contextNode)->item(0),
+                $this->query($expression, $contextNode)->item(0)->parentNode
+            );
         } else {
-            if (is_callable($callbackElse)) {
-                call_user_func($callbackElse);
-            }
+            $this->fireCallback($callbackElse);
         }
 
         return $this;
@@ -335,21 +326,9 @@ public function whenNotEquals(string $expression, ?DOMNode $contextNode, $values
         }
 
         if ($equals === false) {
-            if (is_callable($callback)) {
-                if ($this->query($expression, $contextNode)->item(0)) {
-                    call_user_func(
-                        $callback,
-                        $this->query($expression, $contextNode)->item(0),
-                        $this->query($expression, $contextNode)->item(0)->parentNode
-                    );
-                } else {
-                    call_user_func($callback);
-                }
-            }
+            $this->fireCallback($callback);
         } else {
-            if (is_callable($callbackElse)) {
-                call_user_func($callbackElse);
-            }
+            $this->fireCallback($callbackElse);
         }
 
         return $this;
@@ -368,16 +347,12 @@ public function whenOneExists(array $expressions, array $contextNodes, $callback
     {
         foreach ($expressions as $expressionIndex => $expression) {
             if ($this->exists($expression, $contextNodes[$expressionIndex])) {
-                if (is_callable($callback)) {
-                    call_user_func($callback, $this->query($expression, $contextNodes[$expressionIndex])->item(0), $expressionIndex, $expression);
-                }
+                $this->fireCallback($callback, $this->query($expression, $contextNodes[$expressionIndex])->item(0), $expressionIndex, $expression);
                 return $this;
             }
         }
 
-        if (is_callable($callbackElse)) {
-            call_user_func($callbackElse);
-        }
+        $this->fireCallback($callbackElse);
 
         return $this;
     }

diff --git a/src/XmlDocumentWriter.php b/src/XmlDocumentWriter.php
@@ -11,6 +11,7 @@
 
 use DOMElement;
 use DOMDocument;
+use horstoeko\zugferdublbridge\traits\HandlesCallbacks;
 use horstoeko\zugferdublbridge\XmlDocumentBase;
 
 /**
@@ -24,6 +25,8 @@
  */
 class XmlDocumentWriter extends XmlDocumentBase
 {
+    use HandlesCallbacks;
+
     /**
      * Internal stack
      *
@@ -264,9 +267,7 @@ public function group(string $tagName, $callback): void
         }
 
         $this->startElement($tagName);
-
-        call_user_func($callback);
-
+        $this->fireCallback($callback);
         $this->endElement();
     }
 

diff --git a/src/traits/HandlesCallbacks.php b/src/traits/HandlesCallbacks.php
@@ -0,0 +1,38 @@
+<?php
+
+/**
+ * This file is a part of horstoeko/zugferdublbridge.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace horstoeko\zugferdublbridge\traits;
+
+/**
+ * Trait for handling and firing callbacks
+ *
+ * @category Zugferd-UBL-Bridge
+ * @package  Zugferd-UBL-Bridge
+ * @author   D. Erling <[email protected]>
+ * @license  https://opensource.org/licenses/MIT MIT
+ * @link     https://github.com/horstoeko/zugferdublbridge
+ */
+trait HandlesCallbacks
+{
+    /**
+     * Internal helper function to fire a callback function
+     *
+     * @param  callable $callback
+     * @param  array    ...$args
+     * @return mixed
+     */
+    private function fireCallback($callback, ...$args)
+    {
+        if (!is_callable($callback)) {
+            return;
+        }
+
+        return call_user_func($callback, ...$args);
+    }
+}
diff --git a/src/xml/XmlNodeList.php b/src/xml/XmlNodeList.php
@@ -10,6 +10,7 @@
 namespace horstoeko\zugferdublbridge\xml;
 
 use DOMNodeList;
+use horstoeko\zugferdublbridge\traits\HandlesCallbacks;
 
 /**
  * Class representing a XML node list
@@ -22,6 +23,8 @@
  */
 class XmlNodeList
 {
+    use HandlesCallbacks;
+
     /**
      * Nodelist
      *
@@ -100,20 +103,4 @@ public function forEachMax(int $max, $callback, $callBackBefore = null, $callbac
 
         $this->fireCallback($callbackAfter);
     }
-
-    /**
-     * Internal helper function to fire a callback function
-     *
-     * @param  callable $callback
-     * @param  array    ...$args
-     * @return void
-     */
-    private function fireCallback($callback, ...$args)
-    {
-        if (!is_callable($callback)) {
-            return;
-        }
-
-        call_user_func($callback, ...$args);
-    }
 }