Support jsbundling

[adrienpoly]

I gave it a spin a our app using css_bundling and js_bundling

updating the html works but I am getting this error in the console.

I suppose it is because I don't have importmaps in my app

Given that it seems to work I think it would be best to silence this error

[jorgemanrubia]

Yes @adrienpoly. We only support importmaps for now. jssbundling on our radar, but we need to see build dedicated support for it.

In any case I'll leave this open as we should handle that more gracefully.

[TeriyakiBomb]

I think it'd be good if that was explicit in the readme, it'll save a lot of unnecessary issues being opened 😅
Happy to add if you like

[jankeesvw]

This was also my first question :-)

[jorgemanrubia]

I think a path here would be to add a new endpoint to return the source given a stimulus controller path. That would let us use a unified reloader that works with both jssbundling and importmaps. It would also simplify not having to parse the import maps or reload the HTML document before that.

I'll take a stab at this this week.

[jorgemanrubia]

I think this change will make Hotwire Spark compatible with jsbundling and other alternatives. Tomorrow I'll test and confirm. I'd appreciate it if anyone gives that branch a try to confirm too.

[TeriyakiBomb]

I had a go with the default hello controller - adding the controller to a view updates the html as expected. Modifying the textContents string reloads but returns:

This includes re running the server post install and double checking my gemfile.lock:

remote: https://github.com/hotwired/spark.git revision: e9c255688bd0cdcc581cf0e393ea0597bb2c091c

On a fresh rails install @8.0.1 with jsbundling

[adrienpoly]

I think this change will make Hotwire Spark compatible with jsbundling and other alternatives. Tomorrow I'll test and confirm. I'd appreciate it if anyone gives that branch a try to confirm too.

I gave it a try on our App, Rails 8 /JS bundling / CSS Bundling

The error is gone.

As far as I could tell the changes in the HTML, JS, and CSS are captured and the page is refreshed.
but it seems that I get an extra Turbo visit for every refresh as I see the Turbo blue progress bar popping.
Also probably a consequence of this Turbo visit I loose the scroll position.
At first the page is updated and scroll preserved (using morph I believe) and then the Turbo visit refresh the entire page and reset the scroll position.

Might be something with our app???

[jorgemanrubia]

This is not working to provide hot-reloading for stimulus controllers under jsbundling. Check my reply to @kobaltz here.

I'll play a bit more with the approach, but I'm afraid a saner way for jsbundling will be to get this merged and use replaces instead of morphing for the jsbundling path.

[jorgemanrubia]

Hey @adrienpoly did you try this branch by any chance? That's the only branch that should be triggering a new turbo visit here 🤔

[jorgemanrubia]

I went with a different approach here. It will now detect jsbundling and configure some dedicated options: instead of trying to hot-reload stimulus controllers, it will reload the current page with Turbo (new option introduced by #40).

The problem with hot reloading with jsbundling are dependencies: the browser can't resolve those outside of the bundling environment, so enabling hot-reloading is a much more complex endeavour than when using importmaps.

[adrienpoly]

Hey @adrienpoly did you try this branch by any chance? That's the only branch that should be triggering a new turbo visit here 🤔

I did some more investigating and it is an issue on my side with some legacy esbuild reload that I put in place. Will do some more testing but it is looking good as fare as I could tell

[jorgemanrubia]

I'm closing this as jsbundling will work fine now. I'll be happy to consider hot-reloading for stimulus controllers within this path too if something comes with a good idea that isn't terribly complex.

[adrienpoly]

I'm closing this as jsbundling will work fine now. I'll be happy to consider hot-reloading for stimulus controllers within this path too if something comes with a good idea that isn't terribly complex.

I am going to try hotwire-spark with Ruby Vite. The HMR of RubyVite is amazing. I think there is a sweet spot between Spark html morph updates and RubyVite HMR for JS/CSS. This could be an advanced path to get HMR without importmaps without making Spark too complex neither

[SyedMSawaid]

I am still facing issue with hot-reloading when I change my stimulus controller. Is that not supported yet with js-bundling?

[jorgemanrubia]

@SyedMSawaid have you updated to latest? Also, it could be a caching issue (304 response and, thus, not updating the JS library file). Try disabling the cache to see if that fixes it.

[SyedMSawaid]

The response seems to be 200 for the js files. I have pulled the latest commit directly from GitHub.

This is how my Gemfile, Gemfile.lock and manifest.js looks like.