Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo is not backwards compatible with Turbolinks #67

Closed
jclusso opened this issue Jan 5, 2021 · 2 comments
Closed

Turbo is not backwards compatible with Turbolinks #67

jclusso opened this issue Jan 5, 2021 · 2 comments

Comments

@jclusso
Copy link

jclusso commented Jan 5, 2021

I think it's a bit misleading that there is no information about how Turbo is and isn't backwards compatible with Turbolinks since installing Turbo removes Turbolinks. I'm not sure if the final release version is planned to be backwards compatible, but if not, I think a list of things that are not compatible would be very helpful for people upgrading to Turbo.

@dhh
Copy link
Member

dhh commented Jan 5, 2021

There's no plan for backwards compatibility. Would be nice to have a section in the docs talking about upgrading from Turbolinks to Turbo, though. Mostly it's about renaming events. Please do look into that if you'd like ✌️

@dhh dhh closed this as completed Jan 5, 2021
@hcurotta
Copy link

A section on upgrading would be a great addition 👍

One thing to add to the known gotchas for upgrading is that some JS libs that have added extra code to be compatible with Turbolinks won't work with Turbo and it's not always obvious when this is the case. I got stung today with Intercom. The Intercom JS file is only available from their CDN and it has some checks in it for turbolinks events but not turbo so I'll have to wait for them to make a change before I can upgrade.

https://js.intercomcdn.com/shim.latest.js

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants