Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceed limit results #217

Open
maximvl opened this issue Jun 20, 2016 · 0 comments
Open

Exceed limit results #217

maximvl opened this issue Jun 20, 2016 · 0 comments

Comments

@maximvl
Copy link

maximvl commented Jun 20, 2016

Hi guys, as I can see here https://github.com/etsy/hound/blob/203bd0c7601e28de8c4ae4e922bc0b76938af268/index/index.go#L198 - results are just dropped if they exceed limit (which is constant - 5000).

It is possible to return what was collected so far, instead of just dropping everything. Or, alternatively you can let user set max number of results he wants, of course limited by server's limit too.

For me both are better than what we have now, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants