Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced controls (#adv) blocked by default uBlock Origin Russian list #385

Closed
legoktm opened this issue Feb 25, 2021 · 2 comments
Closed
Labels
good first issue These issues are a great way to get to know Hound's codebase help wanted

Comments

@legoktm
Copy link
Contributor

legoktm commented Feb 25, 2021

I'm forwarding a report from https://phabricator.wikimedia.org/T275820 that the advanced form, which uses the id adv, is in the default blocklist for Russian users of uBlock Origin (and probably other ad blockers), see https://easylist-downloads.adblockplus.org/advblock+cssfixes.txt

Would you be open to renaming the field to something like "advanced" which I think would be clearer and also not likely to be included in default block lists? I think it should be trivial to do and provide a better experience for some users. I'm happy to provide a PR as well, if it would be accepted.

@salemhilal salemhilal added good first issue These issues are a great way to get to know Hound's codebase help wanted labels Mar 30, 2021
@salemhilal
Copy link
Contributor

Sorry for the late reply here! This sounds super reasonable and we would be totally down to accept a PR for this.

@jeffswensen
Copy link
Contributor

Addressed in #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These issues are a great way to get to know Hound's codebase help wanted
Projects
None yet
Development

No branches or pull requests

3 participants