Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve makeVarlist() and rename #96

Open
hrecht opened this issue Mar 21, 2024 · 1 comment
Open

Improve makeVarlist() and rename #96

hrecht opened this issue Mar 21, 2024 · 1 comment
Assignees
Milestone

Comments

@hrecht
Copy link
Owner

hrecht commented Mar 21, 2024

Deprecate the makeVarlist() function, since list_variables() really provides the necessary info, and then users can filter using dplyr or their own code of choice.

This function was an experiment that never really took off, wasn't really in scope of the package, and I have rarely, if ever, seen anyone use it. It is the only function I plan to deprecate rather than supersede or rename.

@hrecht hrecht added this to the censusapi v1.0.0 milestone Mar 21, 2024
@hrecht hrecht self-assigned this Mar 21, 2024
@hrecht hrecht removed this from the v1.0.0 milestone Mar 27, 2024
@hrecht
Copy link
Owner Author

hrecht commented Mar 27, 2024

Upon further reflection I think this function that wraps listCensusMetadata actually serves a potentially useful role and should survive in some form. It could be improved though with better parameter names and maybe other tweaks.

@hrecht hrecht changed the title Deprecate makeVarlist() Improve makeVarlist() and rename Mar 27, 2024
@hrecht hrecht added this to the v1.0.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant