Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMBERJS] Object proxying is depreciated #43

Closed
shennyg opened this issue Apr 1, 2015 · 6 comments · Fixed by #69
Closed

[EMBERJS] Object proxying is depreciated #43

shennyg opened this issue Apr 1, 2015 · 6 comments · Fixed by #69
Assignees
Milestone

Comments

@shennyg
Copy link

shennyg commented Apr 1, 2015

After upgrading ember-cli to 0.2.2 I'm seeing many depreciation notices in my console:

I'm currently running 0.0.19 of ember-google-map, the only difference I see between 0.0.20 is "Always auto-fit bounds feature" So I don't think upgrading will fix it.

DEPRECATION: You attempted to set `lat` from `<app@controller:google-map/marker::ember541>`, but object proxying is deprecated. Please use `model.lat` instead. See http://emberjs.com/guides/deprecations/#toc_objectcontroller for more details.
    at exports.default.mixin.Mixin.create.setUnknownProperty

I'm seeing the depreciation for the following properties:

  • lat
  • lng
  • isWindowVisible
  • zIndex
  • googleEvents
  • isVisible
  • isClickable
  • icon
  • opacity
  • title
  • isDraggable
  • infoWindowTemplateName
  • templateName
  • hasInfoWindow

I can provide any additional info needed.
Thanks!

@huafu huafu added this to the 0.1 milestone Apr 1, 2015
@huafu huafu self-assigned this Apr 1, 2015
@huafu huafu changed the title Object proxying is depreciated [EMBERJS] Object proxying is depreciated Apr 1, 2015
@huafu
Copy link
Owner

huafu commented Apr 1, 2015

Thanks for reporting. I saw that they're removing ObjectController and I don't know if that would be the case for ObjectProxy too.What would be helpful here is if you can find the answer (with references) to these questions (I could look for it but having you doing it would save me some precious time):

  • Will ObjectProxy be removed too?
  • What/how to replace classes extending ObjectController?
  • Is using Controller instead with a model property being an instance of ObjectProxy a good workaround? (that is if `ObjectProxy is not removed as well)

@shennyg
Copy link
Author

shennyg commented Apr 8, 2015

  • Will ObjectProxy be removed too?

I doesn't look like it is happening in v2.0 emberjs/rfcs#45 (comment)

I also didn't see any mentions in the RFCS

  • What/how to replace classes extending ObjectController?

The depreciation guide recommends to use Controller, would that have the methods you need?

  • Is using Controller instead with a model property being an instance of ObjectProxy a good workaround? (that is if ObjectProxy is not removed as well)

I was unable to get much feedback on IRC or Slack. I did get feedback from @malchak, recommending switching to Components in the So-Cal Ember.js Slack:

The only experience I have with this is when you have a list of items and want to perform an action on each individual item, and not the entire list. Instead of using and itemController (ObjectController), each list element rendered inside of a Component. for example, a <table-row>, or <list-item> component. Those are the use cases I've seen
-- @malchak

I'm happy to post to http://discuss.emberjs.com/ if you need more input.

Thank you @huafu

Once we get this figured out I'm happy to add a note to emberjs/ember.js#10143 so others will have additional documentation for ObjectController deprecation.

@btecu
Copy link

btecu commented Apr 9, 2015

Deprecate... Depreciate is a decrease in value.

@huafu
Copy link
Owner

huafu commented Apr 9, 2015

Yeah, I did not even saw that mistake. But it's ok we all understood ;-) I guess @shennyg is like me and English is not his first language.

@tommyblue
Copy link

Hi @huafu, any news on this?
I get thousands deprecation warning using polylines. I'm now using ember-cli 0.2.5
This is not a big problem now, but the ember roadmap after some warnings, fully deprecate some old features, so in the future everything will probably stop working :/

@huafu
Copy link
Owner

huafu commented May 31, 2015

I know, but I am being so busy right now that I cannot do the refactor. It is definitely planned, and don't worry, the project will NOT be abandoned, I need this addon too hehe. But yeah, I can't do that now, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants