Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise submission of trade and order candidate for NSC #341

Closed
jijordre opened this issue Mar 27, 2019 · 1 comment
Closed

Revise submission of trade and order candidate for NSC #341

jijordre opened this issue Mar 27, 2019 · 1 comment
Assignees
@jijordre
Labels
enhancement

Comments

@jijordre
Copy link
Contributor

Description

The current submission of trade and order candidate for NSC is not aligned with the description in https://docs.google.com/document/d/1hIxkW0WJp0bBNTGeAN5dglejjfZf4DEY-gXsgxy6W1w/edit?usp=sharing. A.o. it does not take the cumulative relative transfers and deposits between NSC start and candidate submission into consideration.

This issue describes the adjustments of the implementation for submission of trade and order candidate for NSC in NullSettlementDisputeByTrade to align with the description the document.

Definition of done

  • Submission of trade and order candidate for NSC in NullSettlementDisputeByTrade has been updated
  • Unit tests have been updated

Details & Questions

Depends on
@jijordre jijordre mentioned this issue Jun 20, 2019
Open
@jijordre jijordre self-assigned this Jun 20, 2019
@jijordre jijordre mentioned this issue Jun 20, 2019
Merged
@jijordre
Copy link
Contributor Author

Closed by #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jijordre jijordre

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jijordre