Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChallengeByTradeEvent to {Driip,Null}SettlementChallengeByTrade #360

Closed
jijordre opened this issue Mar 30, 2019 · 1 comment
Closed

Add ChallengeByTradeEvent to {Driip,Null}SettlementChallengeByTrade #360

jijordre opened this issue Mar 30, 2019 · 1 comment
Assignees
@jijordre
Labels
enhancement

Comments

@jijordre
Copy link
Contributor

Description

An event for the successful challenge of a driip or null by trade is currently emitted only by the corresponding DriipSettlementDisputeByTrade/NullSettlementDisputeByTrade. However, the external entry point for the submission of a trade candidate is through the DriipSettlementChallengeByTrade/NullSettlementChallengeByTrade. An event for the successful submission of trade candidate should thus also be added to the latter.

This issue describes the addition of such events.

Definition of done

  • DriipSettlementChallengeByTrade has been updated to emit event upon the successful challenge by trade
  • NullSettlementChallengeByTrade has been updated to emit event upon the successful challenge by trade
  • Unit tests have been updated

Details & Questions

Depends on
@jijordre jijordre self-assigned this Jun 18, 2019
@jijordre jijordre mentioned this issue Jun 18, 2019
Merged
@jijordre
Copy link
Contributor Author

Closed by #414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jijordre jijordre

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jijordre