Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChallengeByOrderEvent to {Driip,Null}SettlementChallengeByTrade #361

Closed
jijordre opened this issue Mar 30, 2019 · 1 comment
Closed
Assignees

Comments

@jijordre
Copy link
Contributor

Description

An event for the successful challenge of a driip or null by order is currently emitted only by the corresponding DriipSettlementDisputeByTrade/NullSettlementDisputeByTrade. However, the external entry point for the submission of a order candidate is through the DriipSettlementChallengeByTrade/NullSettlementChallengeByTrade. An event for the successful submission of order candidate should thus also be added to the latter.

This issue describes the addition of such events.

Definition of done

  • DriipSettlementChallengeByTrade has been updated to emit event upon the successful challenge by order
  • NullSettlementChallengeByTrade has been updated to emit event upon the successful challenge by order
  • Unit tests have been updated

Details & Questions

Depends on

@jijordre
Copy link
Contributor Author

Closed by #414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant