You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The security of the API requires the addition of string properties, one to be populated by the payment sender and one by the nahmii operator.
It is suggested that property data be added to payment.sender. This property should be part of set of properties hashed by the sender (wallet).
Also it is suggested that payment.operatorId be replaced by payment.operator, where operator is sub document containing properties uint256 id and string data. The latter string property only should be part of properties hashed by the operator.
In the same go the global nonce property of payment should be removed both from payment schema as well as from set of properties hashed by the operator. It has no longer any use in smart contracts. Correspondingly fraud challenge smart contracts that trigger on the duplication of global nonce from payment are obsolete and should be removed.
Definition of done
Payment schema has been updated
Hashing of payments has been updated
Relevant fraud challenge contracts have been removed
Unit tests have been updated
Details & Questions
Depends on
The text was updated successfully, but these errors were encountered:
Description
The security of the API requires the addition of string properties, one to be populated by the payment sender and one by the nahmii operator.
It is suggested that property
data
be added topayment.sender
. This property should be part of set of properties hashed by the sender (wallet).Also it is suggested that
payment.operatorId
be replaced bypayment.operator
, where operator is sub document containing propertiesuint256 id
andstring data
. The latter string property only should be part of properties hashed by the operator.In the same go the global
nonce
property of payment should be removed both from payment schema as well as from set of properties hashed by the operator. It has no longer any use in smart contracts. Correspondingly fraud challenge smart contracts that trigger on the duplication of global nonce from payment are obsolete and should be removed.Definition of done
Details & Questions
Depends on
The text was updated successfully, but these errors were encountered: