Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String data and global nonce in payment schema #390

Closed
jijordre opened this issue May 14, 2019 · 1 comment
Closed

String data and global nonce in payment schema #390

jijordre opened this issue May 14, 2019 · 1 comment
Assignees

Comments

@jijordre
Copy link
Contributor

Description

The security of the API requires the addition of string properties, one to be populated by the payment sender and one by the nahmii operator.

It is suggested that property data be added to payment.sender. This property should be part of set of properties hashed by the sender (wallet).

Also it is suggested that payment.operatorId be replaced by payment.operator, where operator is sub document containing properties uint256 id and string data. The latter string property only should be part of properties hashed by the operator.

In the same go the global nonce property of payment should be removed both from payment schema as well as from set of properties hashed by the operator. It has no longer any use in smart contracts. Correspondingly fraud challenge smart contracts that trigger on the duplication of global nonce from payment are obsolete and should be removed.

Definition of done

  • Payment schema has been updated
  • Hashing of payments has been updated
  • Relevant fraud challenge contracts have been removed
  • Unit tests have been updated

Details & Questions

Depends on

@jijordre
Copy link
Contributor Author

Closed by #391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant