Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of claimed amount in TokenHolderRevenueFund #447

Closed
jijordre opened this issue Oct 21, 2019 · 1 comment
Closed

Calculation of claimed amount in TokenHolderRevenueFund #447

jijordre opened this issue Oct 21, 2019 · 1 comment
Assignees
@jijordre
Labels
bug

Comments

@jijordre
Copy link
Contributor

Description

In TokenHolderRevenueFund the calculation of claimed amount across multiple accrual periods need to consider each accrual period separately. Otherwise there are scenarios where e.g. a wallet may obtain revenue in an accrual period during which it had no NII balance blocks.

Definition of done

  • TokenHolderRevenueFund has been updated
  • Unit tests have been updated

Details & Questions

Depends on
@jijordre jijordre added the bug label Oct 21, 2019
@jijordre jijordre self-assigned this Oct 21, 2019
@jijordre jijordre mentioned this issue Oct 21, 2019
Merged
@jijordre
Copy link
Contributor Author

Closed by #448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jijordre jijordre

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jijordre