Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to NahmiiProvider #139

Open
hubiierik opened this issue Dec 18, 2019 · 0 comments
Open

Add options to NahmiiProvider #139

hubiierik opened this issue Dec 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@hubiierik
Copy link
Contributor

When creating a NahmiiProvider
I would like to give it some options
in order to control how the underlying transport layer is working.

Currently we only want to control the timeout parameter of
superagnent. We could require only the timeout parameter in the constructor but it is probably useful to send the options wrapped in an object so that options can be added in the future.

This feaure will also affect the internal object NahmiiRequest,

@hubiierik hubiierik added escalating risk Non-functional issues identified to improve code quality enhancement New feature or request and removed escalating risk Non-functional issues identified to improve code quality labels Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant