Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu popup opening outside of screen, cutting off height #15

Open
WieFel opened this issue Feb 16, 2021 · 14 comments
Open

Menu popup opening outside of screen, cutting off height #15

WieFel opened this issue Feb 16, 2021 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@WieFel
Copy link

WieFel commented Feb 16, 2021

Describe the bug
Similar to #5, when I have a dropdown at the end (bottom) of the screen, the drop down menu opens outside of the screen, leaving only one/two items visible. The rest is cut off.

To Reproduce
Steps to reproduce the behavior:

  1. Put the MenuButton somewhere at the bottom of the screen.
  2. Add like 5 menu items.
  3. Open the menu by clicking the button.
  4. See the menu overflow the screen at the bottom.

Expected behavior
If at the bottom there is not enough space for the menu to fit, it should maybe expand in top direction!?

Screenshots
Screenshot 2021-02-16 at 16 27 48

Screenshot 2021-02-16 at 16 34 53

Smartphone (please complete the following information):

  • iPhone Simulator
  • Android emulator
  • iPhone SE

Additional context

@WieFel WieFel added the bug Something isn't working label Feb 16, 2021
@WieFel
Copy link
Author

WieFel commented Feb 17, 2021

@huextrat will you also take a look at this?
Else I would give it a try and file a PR...

@huextrat
Copy link
Owner

Yes it's noted on my side I just need to find time to do it ;)

I'll keep you informed but it won't be in the next version.

@WieFel
Copy link
Author

WieFel commented Feb 17, 2021

@huextrat perfect, thanks!

@maverick-2013
Copy link

@WieFel Have you resolved the issue somehow? In my case popup is not scrollable at the bottom of the screen.

@WieFel
Copy link
Author

WieFel commented Feb 19, 2021

@maverick-2013 not yet. Waiting for @huextrat to resolve it.

@huextrat
Copy link
Owner

Indeed not yet I don't have too much time at the moment to deal with the issue, if someone wants to help me I'm a taker otherwise it will be early March I hope.

As far as scrolling is concerned you can make your list scrollable with the scrollPhysics' property.

@maverick-2013
Copy link

@huextrat @WieFel My widget structure is: CustomScrollView -> SliverFillRemaining -> Padding -> Column -> MenuButton.

@WieFel
Copy link
Author

WieFel commented Feb 19, 2021

@huextrat I will have a look during next week and try to solve the problem.

@WieFel
Copy link
Author

WieFel commented Feb 22, 2021

@huextrat I am having difficulties with changing the menu opening direction to top.

Maybe you could give me some hint. It seems that PopupRoute by default expands in bottom direction and I don't see a way to change that.

Any ideas? Would be glad if you could have a quick look.

@WieFel
Copy link
Author

WieFel commented Mar 13, 2021

@huextrat still no news about this? 😬

@huextrat
Copy link
Owner

I started a small part of the functionality last week but I don't have much time right now so it's still on hold 🙁

@vivekebiit
Copy link

@huextrat is there any update on this?

@russmvr
Copy link

russmvr commented Jul 26, 2021

I would really like to open the list at the top in this case

@huextrat
Copy link
Owner

Hi, I don't have any time to work on this project right now. If someone wants to make a PR I will take the time to validate it.

Sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants