Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Jupyter Lab export menu wording from "Executable Script" to "Stata (.do)" #7

Open
gaksaray opened this issue Feb 26, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@gaksaray
Copy link

Would it be straightforward to add this functionality? As in @ticoneva's pystata-kernel:

Screen Shot 2023-02-26 at 12 12 22 AM

@hugetim
Copy link
Owner

hugetim commented Feb 26, 2023

That functionality is already present, the same as in pystata_kernel. In Jupyter Lab, it's just referred to as "Executable Script" in that menu, but it will output a .do file.

Are you seeing something different in nbstata's behavior in this regard, or just checking before you try it?

@gaksaray
Copy link
Author

Oh, right. I was expecting to see "Stata (.do)" on Jupyter Lab so must have missed that. Would it make sense (and be possible) to relabel this to be in line with the Jupyter Notebook label?

@hugetim
Copy link
Owner

hugetim commented Feb 26, 2023

I would like that, too. I'll look into whether it's possible.

@hugetim
Copy link
Owner

hugetim commented Feb 26, 2023

Ok, I see one way that is possible but fairly involved. I'd have to make it so that pip-installing nbstata installs a JupyterLab extension that adds a menu item. In principle it shouldn't be too complicated, but my experience of working with the syntax highlighting extension has been pretty exasperating (though maybe that's mostly because I'm trying to do some JavaScript stuff without properly learning JavaScript).

@hugetim hugetim added the enhancement New feature or request label Feb 28, 2023
@hugetim hugetim changed the title Download as .do file Change Jupyter Lab export menu wording from "Executable Script" to "Stata (.do)" Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants